Ensure we use the correct electron-chromedriver version

eclipse-theia / theia-ide

The Eclipse IDE is a modern and open IDE for cloud and desktop. The Theia IDE is based on the Theia platform. The Theia IDE is available as a downloadable desktop application. You can also try the latest version of the Theia IDE online. For more details, see the Readme below.

https://theia-ide.org/#theiaide

MIT License

343 stars 129 forks source link

Ensure we use the correct electron-chromedriver version #326

Closed martin-fleck-at closed 9 months ago

martin-fleck-at commented 9 months ago

What it does

The electron-chromedriver matches the electron version we are using. Mac Silicon (darwin-arm64) has only been supported since v11.0.0 and v9.0.0 build will fail.

Fixes https://github.com/eclipse-theia/theia-blueprint/issues/308

How to test

Build on Mac Silicon.

Review checklist

[x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

pisv commented 9 months ago

Thank you for the fix! The build runs successfully now on my Apple Silicon Mac.