search

eclipse-theia / theia-ide

The Eclipse IDE is a modern and open IDE for cloud and desktop. The Theia IDE is based on the Theia platform. The Theia IDE is available as a downloadable desktop application. You can also try the latest version of the Theia IDE online. For more details, see the Readme below.
https://theia-ide.org/#theiaide
MIT License
343 stars 129 forks source link

The custom toolbar is missing the following icons. #400

Open zhouxinghong opened 1 month ago

zhouxinghong commented 1 month ago

Feature Description:

Hello friend! The custom toolbar is missing the following icons. image

Theia 1.53.200 Windows 10

JonasHelming commented 1 month ago

Hi,

where did you see these icons before? Are you running the Theia IDE?

zhouxinghong commented 1 month ago

The development tool I run is Theia. image

zhouxinghong commented 1 month ago

For example, the following icons can all be integrated into the Theia platform for users to add commands to the toolbar. image

msujew commented 1 month ago

@JonasHelming It's likely that the version that Theia IDE is pulling for @vscode/codicons is outdated.

zhouxinghong commented 1 month ago

image

Use the mouse to click numbers 1 to 5 to demonstrate the function:

image

image

JonasHelming commented 1 month ago

I think I am confused by the screenshots. Do I assume correctly, that the screenshots you uploaded are Wireframes how the tool should look like and that you do not find these icons in Theia to be used on the toolbar? (probably because our codicon version is outdated)?

msujew commented 1 month ago

I've transferred the discussion to the theia-blueprint repo, since the request seems to be to support these toolbar buttons as a default (if I understand @zhouxinghong correctly).

Note that the codicons for that are available, the commands are just not implemented. See also https://microsoft.github.io/vscode-codicons/dist/codicon.html (and search for layout).

zhouxinghong commented 1 month ago

I think I am confused by the screenshots. Do I assume correctly, that the screenshots you uploaded are Wireframes how the tool should look like and that you do not find these icons in Theia to be used on the toolbar? (probably because our codicon version is outdated)?

Yes!

zhouxinghong commented 1 month ago

The function commands corresponding to each button seem to be nowhere to be found.

JonasHelming commented 1 month ago

@zhouxinghong It seems you have a good unerstanding of the underlying issue, as you mentioned that the icons can be integrated into the Theia platform. Are you up for a contribution to fix this?

zhouxinghong commented 1 month ago

@zhouxinghong It seems you have a good unerstanding of the underlying issue, as you mentioned that the icons can be integrated into the Theia platform. Are you up for a contribution to fix this?

Thank you so much for trusting me! 😜 I'd love to be able to contribute to the development of this project!

JonasHelming commented 4 weeks ago

Are you building your own tool based on Theia or are you just using the Theia IDE as is? I am still not 100% sure if I understand your reported issue correctly. Could you describe from a user point of view what exactly the user wants to do? Also: the screenshots you posted, are they from Theia, another tool or are these Wireframes?