search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
20.06k stars 2.5k forks source link

Store localStorage fail when specify --no-cluster #10088

Open linhanyu opened 3 years ago

linhanyu commented 3 years ago

Bug Description:

Theia use localStorage to store layout information. It's wired that store operation failed when specify --no-cluster. I find this problem in 1.16.0. Theia Blueprint not suffer from this issue because it start up without --no-cluster. What more strange is I have set breakpoint in LocalStorageService. It's actually runs into

window.localStorage['_global_:layout'] = serializedData

correctly, but the result seems not flush on disk then app quit.

Steps to Reproduce:

  1. compile and run theia on master branch with --no-cluster
  2. open a terminal tab
  3. close window, then restart. Layout wouldn't restore
  4. open devTools, the layout data were not be update image

Additional Information

vince-fugnitto commented 3 years ago

@linhanyu thank you for reporting the issue :+1: I verified using master with the --no-cluster flag and the layout properly restored for me.

linhanyu commented 3 years ago

@linhanyu thank you for reporting the issue 👍 I verified using master with the --no-cluster flag and the layout properly restored for me.

image image

I test in my macbook and it seems ok for restore layout. It's still cannot be restore in my windows PC. The recently 1.17.2 version suffered from same issue.

linhanyu commented 3 years ago

@linhanyu thank you for reporting the issue 👍 I verified using master with the --no-cluster flag and the layout properly restored for me.

It must recur on my PC. I can provide my environment if remote operation needed.