Open akosyakov opened 7 years ago
T | Promise<T>
execute
isEnabled
isVisible
MenuModelRegistry
findGroup
Add more points if I miss something.
We should keep the KeybindingContext (and registry). It nicely allows to contribute contextual keybindings, especially for users through keymaps.
remove 1-n between command and handlers, by simply let put all the functions of CommandHAndler into Commandremove keybinding context stuff and totally rely on command’s isEnabled()T | Promise<T>
forexecute
,isEnabled
and so on - https://github.com/theia-ide/theia/issues/435isVisible
to a menu itemMenuModelRegistry
, likefindGroup
Add more points if I miss something.