eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
20.05k stars 2.5k forks source link

Problem message is blinking in case it's overlapped with the code hint tooltip #10904

Open fyudanov opened 2 years ago

fyudanov commented 2 years ago

In case of problem message and code hint tooltip both available on the same line, the warning message is sometimes blinking, making it very difficult to read. There are workarounds to use Problems view or find the message iterating with "Go to Next Problem", but still the issues causes bad user experience in result.

The problem seems to be inherited from VSCode, where it's also reproducible.

Details to reproduce consistently:

  1. Plugins installed on Theia:

    "theiaPlugins": {
     ...
    "vscode.python": "https://open-vsx.org/api/vscode/python/1.62.3/file/vscode.python-1.62.3.vsix",
    "ms-python.python": "https://open-vsx.org/api/ms-python/python/2021.11.1422169775/file/ms-python.python-2021.11.1422169775.vsix"
    },
    "theiaPluginsExcludeIds": [
    "ms-python.vscode-pylance"
    ]
  2. Set python.linting.pylintEnabled setting to true Screen Shot 2022-03-22 at 21 26 48

  3. Open new python file, type e.g:

    
    import time

print(time.time())


4. Ensure ```import time``` is underlined
5. Hover on underline text, see the message blinking.

<details>
<summary>Gif example</summary>

![ice_video_20220318-105119](https://user-images.githubusercontent.com/743434/159484114-aaedb49b-b6d9-498b-9b51-86e13008dca3.gif)
</details>

Theia Version: tried on 1.21.
vince-fugnitto commented 2 years ago

@fyudanov thank you for reporting the issue, can you provide additional details on how to consistently reproduce the issue?

The problem seems to be inherited from VSCode, where it's also reproducible.

Given that you were able to reproduce the issue it is likely a problem with the monaco editor which is what we and vscode use. In order to get the fix it might be worthwhile to report an issue there (which ultimately asks you to report the issue to vscode instead).

fyudanov commented 2 years ago

@fyudanov thank you for reporting the issue, can you provide additional details on how to consistently reproduce the issue?

The problem seems to be inherited from VSCode, where it's also reproducible.

Given that you were able to reproduce the issue it is likely a problem with the monaco editor which is what we and vscode use. In order to get the fix it might be worthwhile to report an issue there (which ultimately asks you to report the issue to vscode instead).

Added some more details to reproduce to the issue description.

vince-fugnitto commented 2 years ago

@fyudanov thank you for providing details, I believe it works as expected? The hover details should be merged together:

https://user-images.githubusercontent.com/40359487/159544138-0adb8e43-d1a5-46a1-a716-d12a7d5d992d.mp4

fyudanov commented 2 years ago

@vince-fugnitto I didn't notice this before, thanks for help.

Still I suppose, the blinking behavior (like it's shown in gif in the issue description) can be considered as a problem (probably minor one), because it can be confusing to the user, affecting UX in result.

vince-fugnitto commented 2 years ago

@fyudanov I wasn't able to reproduce the issue you experienced unfortunately, but given you were also able to reproduce it in vscode I believe an issue should be filed there, the fix would be to properly handle it at the monaco-editor level.

You can also play around with this preference, to control the delay editor.hover.delay.