Use 'openWithSystemApp' to open uri when 'env.openExternal' requested

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.

http://theia-ide.org

Eclipse Public License 2.0

19.84k stars 2.48k forks source link

Use 'openWithSystemApp' to open uri when 'env.openExternal' requested #13676

Closed dhuebner closed 2 months ago

dhuebner commented 3 months ago

What it does

When vscode.env.openExternal is requested, opens the URI using window.electronTheiaCore.openWithSystemApp instead of opening the file in the default Theia editor.

See #13535

How to test

Follow the "Steps to Reproduce" instructions in #13535

Follow-ups

Review checklist

[x] As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

As a reviewer, I agree to behave in accordance with the review guidelines

rschnekenbu commented 2 months ago

Note: I tested on a rebase of the current branch on master, to check on latest master. It took me a long time to be able to review this one :/

dhuebner commented 2 months ago

@rschnekenbu Thank you very much for the re-view!