VSCode Tab API not working for multiple tab bars

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.

http://theia-ide.org

Eclipse Public License 2.0

19.84k stars 2.48k forks source link

VSCode Tab API not working for multiple tab bars #13677

Open jonah-iden opened 3 months ago

jonah-iden commented 3 months ago

Bug Description:

It seems like when https://github.com/eclipse-theia/theia/pull/12109 was implemented the viewCollumn property was not correctly implemented. This needs to be retrofitted. see https://github.com/eclipse-theia/theia/pull/12109/files#diff-cf9def33dbeeb0cd3fa2f7b8026959104e2461870a8c5c8c1dfd7487fad6ac9eR145

Above that there are some more discrepancies.

in VSCode the active tabbar is always set
there is always at least one tabgroup existing

tsmaeder commented 3 months ago

The fact that TabGroups.activeTabGroup can be undefined causes an Exception at startup in the typescript-language-features 1.88.1 version

jonah-iden commented 3 months ago

@tsmaeder if you find the time could you by any chance test this extension in vscode. Out of some weird reason the tab API seems to be broken there and im only receiving close events in the extension.

Edit: Forget that i just made a really dumb mistake