search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.83k stars 2.48k forks source link

TabGroup.viewColumn and Editor.viewColumn are out of sync for the same editor. #13679

Open tsmaeder opened 3 months ago

tsmaeder commented 3 months ago

Bug Description:

When starting up typescript-language-features 1.881 the context key typescript.isManagedFile is never set. Analyzing the problem led to finding out that the extension fails to find the active typescritpt editor due to this comparison failing for the single open editor: 

editor.viewColumn === tab.group.viewColumn;

editor.viewColumn is one and tab.group.ViewColumn is 2, but there is only one editor open.

Steps to Reproduce:

n/a

Additional Information

tsmaeder commented 3 months ago

Remove the workaround from https://github.com/eclipse-theia/theia/pull/13673 once we have a fix here.

tsmaeder commented 2 months ago

Turns out this problem leads to pretty much all commands from typescript-language-features being disabled, even stuff that is not context dependent like "restart tsserver".

tsmaeder commented 2 months ago

https://github.com/microsoft/vscode/blob/main/extensions/typescript-language-features/src/ui/activeJsTsEditorTracker.ts#L64