eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.84k stars 2.48k forks source link

Propagate "Save As" operation to plugin host #13689

Closed msujew closed 2 months ago

msujew commented 3 months ago

What it does

Closes https://github.com/eclipse-theia/theia/issues/13688

Ensures that any new file created from a "Save As" operation correctly fires the onDidCreateFiles event in the plugin host. Also greatly simplifies the "Save As" operation logic.

How to test

  1. Download and install the test extension
  2. Open a file and change it.
  3. Use the save as operation and point the file picker to a non-existing file.
  4. Ensure that a notification pops up (triggered by onDidCreateFiles)
  5. Ensure that the "Save As" operation behavior still works as expected

    Review checklist

Reminder for reviewers

JonasHelming commented 2 months ago

@msujew I think we can merge this?