eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.55k stars 2.46k forks source link

Delegate showing help to the back end process. #13729

Closed tsmaeder closed 1 month ago

tsmaeder commented 1 month ago

What it does

Fixes #13727

The approach is to add non-functional cli contributions for any arguments that concern only the electron-main process. Currently, we have a bit of confusion between the theia cli tool, which is mostly a development-time tool (theia build, etc.) and the actual Theia application executable (TheiaIde.exe). It would probably make sense to evolve the architecture in a way that all possible command line options are available to all "customer-facing" cli tools and can be selectively forwarded to the back-end, plugin-process and any other processes making up Theia.

Contributed on behalf of STMicroelectronics

How to test

The closest equivalent to what the TheiaIDE.exe does is the "Launch electron back end" launch configuration. To test, you can add parameters after the initial . parameter (which is a parameter to Electron). One can also use npx theia start <...params> on the command line in the electron or browser example. In these way, test that the help commands output reasonable advice and that start parameters are properly handled.

Follow-ups

Review checklist

Reminder for reviewers