eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.55k stars 2.46k forks source link

Fix an API test failure on macOS #13732

Closed pisv closed 1 month ago

pisv commented 1 month ago

What it does

Before this fix, Monaco API KeybindingService.resolveKeybinding test was failing on macOS with

AssertionError: expected { label: '⌃⇧⌥⌘K', …(6) } to deeply equal { label: '⌃⇧⌥⌘K', …(7) }
+ expected - actual

{
 "WYSIWYG": true
 "ariaLabel": "⌃⇧⌥⌘K"
+  "chord": false
 "dispatchParts": [
   "ctrl+shift+alt+meta+K"
 ]
 "electronAccelerator": "Ctrl+Shift+Alt+Cmd+K"

The chord: false was removed from the expected object for other platforms as part of #13217.

This fix removes it from the expected object for macOS.

How to test

Run yarn test on macOS.

Review checklist

Reminder for reviewers

msujew commented 1 month ago

@JonasHelming Someone on your side available to review this? Neither Jonah nor I have a Mac.

rschnekenbu commented 1 month ago

@msujew We don't have Macs here either.

tsmaeder commented 1 month ago

I have one at home, but I'm not there right now ;-)

tsmaeder commented 1 month ago

@pisv which test suite is this?

pisv commented 1 month ago

examples/api-tests/src/monaco-api.spec.js