Notebooks: Aligned scroll into view behaviour with vscode - Githubissues

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.

http://theia-ide.org

Eclipse Public License 2.0

19.55k stars 2.46k forks source link

Notebooks: Aligned scroll into view behaviour with vscode #13742

Closed jonah-iden closed 1 month ago

jonah-iden commented 1 month ago

What it does

As in vscode clicking a cell to select it or deleting a cell and changing the selection that way should not move the newly selected cell into view

How to test

In a notebook test:

clicking on a cell slightly outside of the view. Should not scroll
deleting a cell. Should not scroll
inserting new cell: Should scroll
arrow keys. With and without text focus. Should scroll

Follow-ups

Review checklist

[x] As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

As a reviewer, I agree to behave in accordance with the review guidelines

jonah-iden commented 1 month ago

seems i forgot two places two disable scrolling. Thanks for finding! Should be fixed now