Open xai opened 4 months ago
@xai What is the state of this?
@xai What is the state of this?
As I commented in the related issue, I feel that the added protected function might be living in the wrong place. But it works, and I do not know what would be a better file/package for that function, so I am just going to remove the draft state now and hope for input from a reviewer.
@tsmaeder alerted me that the property seems to be ignored in certain cases:
yarn download:plugins
while building or clear plugins/ directory).Merging as is does not make sense, because it will not work in most cases (i.e., all built-in extensions are present). So, I am going to debug into this to find out which extension we are having this feature interaction with.
What it does
When the
files.insertFinalNewline
property is set to true, formatOnSave() will ensure that the file ends with a newline character instead of always removing a final empty line.Fixes #13475
Contributed on behalf of STMicroelectronics
How to test
"editor.formatOnSave"
totrue
in the workspace settings."files.insertFinalNewline"
totrue
in the workspace settings.Follow-ups
Review checklist
Reminder for reviewers