There was a problem when closing an editor to the right of the current or the most right one and then changing the theme, the editors would not update correctly. Was probably introduced by the secondary window changes. This should fix it.
Also fixes the small issue of widget not attached errors from the webviews when closing a notebook editor with outputs
How to test
Theming:
open at least two editors, the right one should be a standalone one. Left can be either notebook or standalone.
close the right editor.
change the theme to the opposite theme (dark/light)
see that it now updates correctly (previously the editor would stay on the previous color)
Widget not attached:
just open a notebook with outputs
close it
there should be no widget not attached errors in the console
Follow-ups
Review checklist
[x] As an author, I have thoroughly tested my changes and carefully followed the review guidelines
What it does
There was a problem when closing an editor to the right of the current or the most right one and then changing the theme, the editors would not update correctly. Was probably introduced by the secondary window changes. This should fix it.
Also fixes the small issue of
widget not attachederrors from the webviews when closing a notebook editor with outputsHow to test
Theming:
Widget not attached:
Follow-ups
Review checklist
Reminder for reviewers