search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
20.09k stars 2.5k forks source link

Google Cloud extension fails to load. #13779

Open kineticsquid opened 5 months ago

kineticsquid commented 5 months ago

Bug Description:

I use the Google Cloud extension on VS. I tried it on the latest Theia release and it fails on loading:

Screenshot 2024-06-06 at 12 59 26 PM

I confirmed the latest release of the extension on my VS installation and then tried various combinations of un-installing, re-instalilng and restarting Theia, but no luck.

Additional Information

msujew commented 5 months ago

It's likely that the extension is just using an unbundled require('node-pty') call and expects that vscode just makes the library available in the extension host. There is a bit of discussion surrounding this practice and it's discouraged by the maintainer of node-pty (who is a major vscode contributor), see https://github.com/microsoft/node-pty/issues/582.

Anyway, an obvious fix to this would be to expose the node-pty library in our plugin host. As far as I know, vscode is doing this by bundling their app in a smart way, while we just bundle everything, which makes plain node.js require calls fail.

kineticsquid commented 5 months ago

@msujew Thanks for the explanation. To make sure I understand, this is a change you would make to expose the library?

msujew commented 5 months ago

@kineticsquid We could do that, yes. It's not ideal, since it's discouraged, but it's not like VSCode actually punishes extension developers that just side-load vscode's owns dependencies.

msujew commented 5 months ago

@tsmaeder Your opinion on this? VS Code exposes its own native dependencies to its extensions. Doing the same would require us to keep our versions of these dependencies up to date with VS Code.

tsmaeder commented 5 months ago

@kineticsquid do you mean this one? https://marketplace.visualstudio.com/items?itemName=GoogleCloudTools.cloudcode

@msujew @kineticsquid I cannot express in polite conversation just what I think of the practice of depending on the implementation details of your host platform if said platform goes out of its way to provide a well-defined API for interacting with that platform.

As for aligning our dependencies with VS Code: that way lies madness! The Theia platform is implemented differently from VS Code and therefore necessarily has different dependencies and dependency versions. If we start doing this, we would also make the integration work of our adopters infinitely more difficult. So as far as I am concerned, it's a hard no!

My suggestion would be to go complain to the Google team and complain loudly! If folks go out of their way to be incompatible with Theia, I don't think making those cases work is a reasonable use of our limited resources.

What we do for the built-in's is to package some dependencies in our build script: https://github.com/eclipse-theia/vscode-builtin-extensions/blob/master/src/package-vsix.js#L71. One way to go would be to rebundle the extension in a custom build script for open-vsx to include the proper version of node-pty during the extension build.

kineticsquid commented 5 months ago

@tsmaeder Yes, that's the extension I was referring to. And I certainly defer to your judgement in how we approach this inconsistency. If we start with the fact that the implementations of the platforms are different and so will cause inconsistencies in extension behavior, what's the best approach? Do we ask extension developers to make changes or do we go the custom build script approach? Seems the latter could get fragile.