Improved notebook cell drag images

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.

http://theia-ide.org

Eclipse Public License 2.0

19.38k stars 2.45k forks source link

Improved notebook cell drag images #13791

Closed jonah-iden closed 3 weeks ago

jonah-iden commented 3 weeks ago

What it does

This improves the rendering of drag images for notebook cells and aligns to more how they look in vscode.

How to test

Open notebook and try dragging a cell. Code and mardown cells have different drag image renderers

Follow-ups

Review checklist

[x] As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

As a reviewer, I agree to behave in accordance with the review guidelines

jonah-iden commented 3 weeks ago

@msujew thanks, good catch. fixed it the way you suggested for. Not super happy with that though since in python iirc you use ``` to indicate multi line strings.

The scrolling seems to be general theia problem. Same thing happens in the file explorer and other places as soon as you drag anything. If there is not already an issue for that we should probably reate one

msujew commented 3 weeks ago

@jonah-iden AFAIK python uses """. Anyway, I found a way to correctly escape everything and pushed it to your branch.