Fix the issue of not updating recentList on unload

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.

http://theia-ide.org

Eclipse Public License 2.0

19.38k stars 2.45k forks source link

Fix the issue of not updating recentList on unload #13797

Open newliuyaoyan opened 3 weeks ago

newliuyaoyan commented 3 weeks ago

What it does

Fixed the issue of not updating the recentList file after the window was closed. This issue is caused by the late update of files when the window is closed.

How to test

After each window close, check if the recentList file has been updated

Follow-ups

Review checklist

[x] As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

As a reviewer, I agree to behave in accordance with the review guidelines

newliuyaoyan commented 3 weeks ago

Thank you for your help. I have now made the modifications as you suggested

JonasHelming commented 1 week ago

@msujew Can you re-review, please?

msujew commented 1 week ago

@JonasHelming I've started looking into this, but encountered some unexpected behavior (which I'm not sure about how to fix). Given that this in general is a pretty low-prio issue IMO, I'll get to it for the next release.