The settings page does not support internationalization

[fly-bue]

Bug Description:

I found that internationalization was not implemented in the preference-tree-widget.ts and preference-node-renderer.ts files, and I tried to solve this problem. As follows:

  // preference-tree-widget.ts
  protected override toNodeName(node: TreeNode): string {
   const visibleChildren = this.model.currentRows.get(node.id)?.visibleChildren;
       // todo
        const baseName = nls.localizeByDefault(this.labelProvider.getName(node));
        const printedNameWithVisibleChildren = this.model.isFiltered && visibleChildren !== undefined
            ? `${baseName} (${visibleChildren})`
            : baseName;
        return printedNameWithVisibleChildren;
    }

  // preference-node-renderer.ts
 protected createDomNode(): HTMLElement {
        const wrapper = document.createElement('ul');
        wrapper.className = 'settings-section';
        wrapper.id = `${this.preferenceNode.id}-editor`;
        const isCategory = Preference.TreeNode.isTopLevel(this.preferenceNode);
        const hierarchyClassName = isCategory ? HEADER_CLASS : SUBHEADER_CLASS;
        // todo
        const name = nls.localizeByDefault(this.labelProvider.getName(this.preferenceNode));
        const label = document.createElement('li');
        label.classList.add('settings-section-title', hierarchyClassName);
        label.textContent = name;
        wrapper.appendChild(label);
        return wrapper;
    }

When does the team plan to support internationalization of the settings page?

Steps to Reproduce:

Additional Information

Operating System: Windows 11 Theia Version: master

[msujew]

Hey @fly-bue,

the main issue is that these names are dynamically generated from the IDs/names of the preferences. They're not real named groups. VS Code also struggles with this, and AFAIK also doesn't translate the names of the preference groups.

However, we can maintain a list of translations for known groups. Note that the preferences contributed by plugins won't have a translated group name.

[fly-bue]

Thanks for the reply.I found that some translations are already implemented in this repo, but they are not used in Theia settings page yet.

[msujew]

I see. Seems like VS Code has actually started translating those preference groups. That wasn't there the last time I worked on the feature. I'll implement this soon.