search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.29k stars 2.45k forks source link

Status of `search.exclude` setting #13823

Open madmini opened 2 weeks ago

madmini commented 2 weeks ago

Is the settings property Search: Exclude (search.exclude) planned for Theia IDE? Are there alternatives? Description in VSCode:

Configure glob patterns for excluding files and folders in fulltext searches and file search in quick open. To exclude files from the recently opened list in quick open, patterns must be absolute (for example **/node_modules/**). Inherits all glob patterns from the Files: Exclude setting.

In https://github.com/eclipse-theia/theia/issues/7273#issuecomment-594645876 the sentiment is to add it, but PR #8406 (which would have added it) was closed with the following comment:

Closing in favor of: https://github.com/eclipse-theia/theia/pull/8433 which has the minimal changes.

The search.exclude preference can be added at a later time, it should not exist in siw since it is ultimately used in different places such as @theia/file-search as well.

I cannot find another reference to search.exclude after this.

I am asking because the absence of a default value for this property has caused yzhang-gh/vscode-markdown#1357.

msujew commented 2 weeks ago

Hey @madmini,

there was probably little need on the adopter side to implement search.exclude in the meantime. If you are interest, please feel free to contribute something in that direction. I'd be happy to review any PR.