Closed jonah-iden closed 2 weeks ago
This improves the visible keybindings in context menus by not showing keybindings that are inactive in the current context.
For example add a keybinding like this to some keybinding contribution
{ command: CommonCommands.UNDO.id, keybinding: 'z', when: 'notebookEditorFocused', }
previously this was the always shown as Z in the context menu regardless of if a notebook editor was focused.
Z
Now this should still normally be ctrl/cmd+z but when a notebook editor is focused it should show as Z
ctrl/cmd+z
What it does
This improves the visible keybindings in context menus by not showing keybindings that are inactive in the current context.
How to test
For example add a keybinding like this to some keybinding contribution
previously this was the always shown as
Z
in the context menu regardless of if a notebook editor was focused.Now this should still normally be
ctrl/cmd+z
but when a notebook editor is focused it should show asZ
Follow-ups
Review checklist
Reminder for reviewers