eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.29k stars 2.45k forks source link

Serialize saveables to disk for "Save As" #13833

Closed msujew closed 2 weeks ago

msujew commented 2 weeks ago

What it does

Adds a new optional serialize method to all Saveable objects. This method will be used in case the saveable is not directly string-serializable (such as notebooks) for the "Save As" action.

How to test

  1. Open a ipynb file, and edit it
  2. Save it to a new file using Save As...
  3. The new file should contain all old changes + new changes
  4. The old file should be correctly reverted

Please also confirm that the "Save As" operation still works for normal text editors

Review checklist

Reminder for reviewers