eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.29k stars 2.45k forks source link

Add support for 256 truecolor #13853

Closed sgraband closed 1 day ago

sgraband commented 1 week ago

What it does

Beforehand the terminfo[colors] and COLORTERM were not set properly. The terminal already supports 256 truecolor, but cli tools might not use it, as the env variables were not set correctly. This is fixed with this PR, the color is not set to 256 and COLORTERM is set to truecolor.

Fixes #13523.

How to test

  1. Start the application
  2. Open the terminal
  3. Run print $terminfo[colors] and echo $COLORTERM
  4. Observe that the output is 256 and truecolor respectively.

Follow-ups

Review checklist

Reminder for reviewers