search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.86k stars 2.48k forks source link

Deprecate preview support for markdown files #13895

Open msujew opened 2 months ago

msujew commented 2 months ago

Since we're now deprecating the Git extension (#12745) in favor of using VS Code's builtins, I'm wondering whether it makes sense to remove the markdown preview feature from the @theia/preview package. IMO it's a worse version of the vscode.markdown builtin extension and bloats the bundle due to the inclusion of highlight.js (and its 1.3mb minified bundle size).

msujew commented 1 month ago

This has been discussed in last weeks dev call. We will likely deprecate/remove the feature after sending out an info about this via the Theia mailing list.

I aim to remove the related code for the August (1.53) release.

zhouxinghong commented 1 month ago

@msujew I've asked VSCode many times about these problems but they refused to deal with them, besides VSCode is very bloated and slow now, so when I found Theia I decided to abandon VSCode completely and move to Theia, I hope that the birth of the Theia project means that it's an enhancement and improvement of VSCode, at least in some ways, it should have its own unique features. I hope that the Theia project is meant to be an enhanced and improved version of VSCode, at least in some ways. I hope you will consider these suggestions.

Thank you very much for your hard work! 👍😜👏

zhouxinghong commented 1 month ago

image The preview button with the arrow pointing to it has very complete support for audio and video previews, and the previews are much better than the vscode Markdown previews, so please keep this feature. Also, vscode Markdown is a feature-crippled presence, consider removing the vscode Markdown preview.