search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.87k stars 2.48k forks source link

If there are spaces in the image path then it won't render in Markdown. #13997

Open zhouxinghong opened 1 month ago

zhouxinghong commented 1 month ago

Bug Description:

Steps to Reproduce:

If there are spaces in the image path then it won't render in Markdown, like this:

![](One PGF GGH_MMM/PGF-BGF.png)
![](One%20PGF%20GGH_MMM/PGF-BGF.png)

image

Additional Information

msujew commented 1 month ago

Hey @zhouxinghong,

![](One%20PGF%20GGH_MMM/PGF-BGF.png)

This renders for me just fine in the preview contributed by the vscode extension for markdown (the preview button on the right). This is working as expected, as whitespace in markdown URLs is not valid syntax. The other markdown preview is deprecated (see https://github.com/eclipse-theia/theia/issues/13895) and will be removed soon.

zhouxinghong commented 1 month ago

@msujew vscode markdown preview does not support audio preview and video window maximization. For example, insert the following video in markdown:

<video controls muted preload="auto" poster="https://cdn.up/iAgMxQoglUZ4uh7m4vFIhB5bLuljfjAtoBw8dOUV.jpg" src="https://ss201.dd.sg/video/hb.mp4">
</video>
msujew commented 1 month ago

@zhouxinghong That's a separate issue that should be raised with the vscode team.

zhouxinghong commented 1 month ago

@msujew I've asked VSCode many times about these problems but they refused to deal with them, besides VSCode is very bloated and slow now, so when I found Theia I decided to abandon VSCode completely and move to Theia, I hope that the birth of the Theia project means that it's an enhancement and improvement of VSCode, at least in some ways, it should have its own unique features. I hope that the Theia project is meant to be an enhanced and improved version of VSCode, at least in some ways. I hope you will consider these suggestions.

Thank you very much for your hard work! 👍😜👏

zhouxinghong commented 1 month ago

image The preview button with the arrow pointing to it has very complete support for audio and video previews, and the previews are much better than the vscode Markdown previews, so please keep this feature. Also, vscode Markdown is a feature-crippled presence, consider removing the vscode Markdown preview.

msujew commented 1 month ago

@zhouxinghong Can you please raise your concerns over at the markdown preview deprecation issue? https://github.com/eclipse-theia/theia/issues/13895

In the meantime, I'll reopen this issue.