Drop nsfw support - Githubissues

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.

http://theia-ide.org

Eclipse Public License 2.0

19.91k stars 2.49k forks source link

Drop nsfw support #14015

Open rschnekenbu opened 1 month ago

rschnekenbu commented 1 month ago

NSFW (node-sentinel-file-watcher) is one of our dependencies and was not updated for the last 2 years.

In the context of #13957, there may be some evolution to do on the FileSystemWatcher mechanism, it could be a good point to evaluate changing this library to a newer one. In short about these evolutions:

file-system-event-service-ext-impl.ts may follow evolutions as indicated in its comment
the proposed API used by typescript require API and behavior evolution on our current framework.

As a note: VS Code is now using parcel (https://github.com/parcel-bundler/watcher).

msujew commented 1 month ago

For the necessary changes, see https://github.com/eclipse-theia/theia/pull/12784 :)