eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
20.06k stars 2.5k forks source link

Failing Tests with Parcel Watcher #14257

Open tsmaeder opened 1 month ago

tsmaeder commented 1 month ago

Bug Description:

In https://github.com/eclipse-theia/theia/pull/14194, two Playwright tests fail on Linux only. These are in theia-explorer-view-tests.ts: 'should delete nested folder "sampleDirectoryCompact/nestedFolder1/nestedFolder2"' and 'should delete compact folder "sampleDirectoryCompact/nestedFolder1"'. The suspicion is that this is actually a timing-dependency that only occurs on Linux. Here's the analysis from the linked PR:

Steps to Reproduce:

I've looked into the failures of the Playwright tests. They only fail on Linux. IMO, this is a bug in the "compressed tree" and is probably unrelated to the change at hand. So, with the resources folder from the playwright test, you can do the following scenario:

delete "nestedFolder2"
Observe: there is no change visible and a console.log in the rendering of the compressed rows is not hit.
Select the row in question
Observe: nestedFolder2 disappears from the row.

The same events seem to be sent on Linux and Windows, so my suspicion is that this is a reordering of async blocks du to the different timings on the respective platforms.

Additional Information

cdietrich commented 1 month ago

maybe https://github.com/parcel-bundler/watcher/issues/183

msujew commented 1 month ago

@cdietrich Might be, but unlikely. This issue is 100% reproducible in CI (and likely an issue of our compressed tree implementation). As far as I can tell your parcel watcher issue seems to be more random, right?

cdietrich commented 1 month ago

yes its quite random