Open kittaakos opened 6 years ago
Instead of commenting out every line of execution within the test, why not using "it.skip". Later, we will see there is a test, but not completed yet and it will be easier to comeback to that specific test and fix it
It results in exactly the same pending
state. Feel free to update.
The result is almost the same, mocha result will flag there is a test that is not executed at the end. So just by looking at the mocha resulkt, we will know there is a test that was not performed . Ifd we comment the line, mocha will show all test passed
Are you talking about this?
node --inspect-brk=13419 node_modules/mocha/bin/_mocha /Users/akos.kitta/git/theia/packages/file-search/src/node/file-search-service-impl.spec.ts --no-timeouts --colors --opts /Users/akos.kitta/git/theia/configs/mocha.opts
Debugger listening on ws://127.0.0.1:13419/90ecdf6b-45a7-49d3-b027-4a97a83f2515
Debugger attached.
search-service
✓ shall fuzzy search this spec file (49ms)
- shall respect nested .gitignore
✓ shall cancel searches
2 passing (65ms)
1 pending
Waiting for the debugger to disconnect...
Yes
Good, that's the current state. But you could still update if you want.
Fine with me, it just to be able to track which tests are not fully executing at the end.
this issue was reported here https://github.com/BurntSushi/ripgrep/issues/829 and seems that some people are working on the fix
Depends on #1584.
See the pending tests here: https://github.com/theia-ide/theia/blob/479ac6c77944f0234059777ed71053d754ee5262/packages/file-search/src/node/file-search-service-impl.spec.ts#L40