highlighting feature in the monaco-quick-open-service doesn't always work

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.

http://theia-ide.org

Eclipse Public License 2.0

19.9k stars 2.49k forks source link

highlighting feature in the monaco-quick-open-service doesn't always work #1611

Open elaihau opened 6 years ago

elaihau commented 6 years ago

peek 2018-03-29 10-38

Also see the discussion in https://github.com/theia-ide/theia/pull/1512#discussion_r178042342

I did some debugging, it turned out that the code ended up sending the same data into QuickOpenWidget.setInput() function https://github.com/theia-ide/theia/blob/master/packages/monaco/src/typings/monaco/index.d.ts#L365 in scenarios where the highlighting worked and didn't work.

Looks like it is an external issue.

epatpol commented 6 years ago

It might be worth it to try and investigate if monaco already has an issue related to this, and if not maybe open one. As long as it's not too complicated to provide an easy to reproduce example of the monaco quick open not highlighting correctly, I think this would be ideal (unless it's not a monaco problem).

JonasHelming commented 3 years ago

@elaihau Could you retest this with the latest version and if you can reproduce it, provides steps how to do so?

FernandoAscencio commented 1 year ago

Is this still an issue? Do you have some of the code to reproduce?