Open evidolob opened 5 years ago
In my opinion, the 1'st option sounds nice since it provides better compliance with VSCode
Once this issue is fixed we should get rid of that workaround https://github.com/theia-ide/theia/blob/d4e3b5ec6c0ea30b4e7941e8fc497d07fa05ed3c/packages/plugin-ext/src/main/browser/menus/menus-contribution-handler.ts#L53-L58 and enable the tests here https://github.com/theia-ide/theia/blob/d4e3b5ec6c0ea30b4e7941e8fc497d07fa05ed3c/packages/plugin-ext/src/main/browser/menus/menus-contribution-handler.spec.ts#L77
I don't think it is related to VS Code extension support, but pure Theia plugins only.
@evidolob @azatsarynnyy Is it still relevant?
I guess it should be already fixed by https://github.com/eclipse-theia/theia/issues/3994
Exception:
We add menu items before plugin able to register commands, so I see two options to solve this:
package.json
file, in commands contribution section(like in VSCode), we keep in plugin code only command handler registration.menu
contribution point frompackage.json
, and configure menu only from plugin code, using new plugin API for menu, after plugin register commands.