eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
20.06k stars 2.5k forks source link

reconsider starting debug adapters and language servers as raw processes #3688

Open akosyakov opened 5 years ago

akosyakov commented 5 years ago

RawProcess is a process started by a user and should be executed with user env, e.g. tasks. Language servers and debug adapters (not debuggees) are not processes started by a user and should be executed with Theia (or own) env which can be different from user env, e.g. user-container vs Theia-container running side-by-side.

I think language servers and debug adapters should be spawned/forked with pure child_process module by default.

// cc @svenefftinge

akosyakov commented 5 years ago

Another point is to which processes the end user can have an access. For tasks it makes sense to give an access, but should the end user have access to language servers and debug adapters processes? Especially in the cloud case, when deploying and managing Theia is not the responsibility of end users.