[quality][question] The `SymbolKind` enum is defined three times in the repo

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.

http://theia-ide.org

Eclipse Public License 2.0

20.11k stars 2.5k forks source link

[quality][question] The `SymbolKind` enum is defined three times in the repo #3810

Closed kittaakos closed 5 years ago

kittaakos commented 5 years ago

This is super minor. I found it accidentally in the source.

@benoitf, can we use the SymbolKind from the @theia/languages instead of redefining it twice in the plug-in extensions? @theia/plugin does not directly depend on @theia/languages but it is available through @theia/monaco. Thanks!

benoitf commented 5 years ago

hello @kittaakos I had the same remark (about the twice, not the third ! :-) https://github.com/theia-ide/theia/pull/3483/files#r233357173

benoitf commented 5 years ago

@azatsarynnyy @evidolob ?

azatsarynnyy commented 5 years ago

I've removed the one from the @theia/plugin https://github.com/theia-ide/theia/pull/3814

azatsarynnyy commented 5 years ago

SymbolKind enum from the @theia/languages is different for some reason

kittaakos commented 5 years ago

is different for some reason

I see. Thanks for the feedback, @azatsarynnyy!

They're different because

for VS Code (and monaco), it starts with 0
for the LS, it starts with 1.

Please close this issue if it is done. Thanks!

kittaakos commented 5 years ago

Closed via https://github.com/theia-ide/theia/pull/3814.