search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.9k stars 2.49k forks source link

make sure that all packages are published by yarn #4083

Open akosyakov opened 5 years ago

akosyakov commented 5 years ago

Again some packages were missing for next version. For some reason yarn or lerna fail to publish some packages, but report that they are published. We should figure out the root cause. For now maybe at least have a script checking after deployment whether all packages were published and if not tries again or fails.

Following issues are caused by it: https://github.com/theia-ide/theia/issues/3964 https://github.com/theia-ide/theia/issues/4067

svenefftinge commented 5 years ago

Just see it with the current next again.

akosyakov commented 5 years ago

It does not seem to be lerna issue: https://github.com/lerna/lerna/issues/1344#issuecomment-392287921

During the build old yarn version is used, we can try to bump it and see whether it helps. Adding a script to check whether everything was published would be helpful anyway.

akosyakov commented 5 years ago

We've added a script to fail the build if some extensions are not published. For instance, https://travis-ci.org/theia-ide/theia/jobs/482768793 failed because:

(ERR) @theia/bunyan@0.4.0-next.92c64f94: NOT published
(ERR) @theia/editorconfig@0.4.0-next.92c64f94: NOT published

As first, I will try to upgrade yarn version for travis. If it does not help we can try to run npm publish again for each failed package, similar what we do during the release.

Other ideas?

akosyakov commented 5 years ago

The build with latest yarn succeeded: https://travis-ci.org/theia-ide/theia/jobs/482822382#L1928

Let's wait till next week, if next build are green by then then this issue can be closed.

akosyakov commented 5 years ago

All packages seem to be always published now. But our script to check is a bit flaky and produce false positive. We could loop it over suspicious packages once more with some delay.