search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
20.12k stars 2.5k forks source link

[json] Auto-closing quotes does not work in JSON files #4942

Closed kittaakos closed 5 years ago

kittaakos commented 5 years ago

Theia TS/JS: screencast 2019-04-18 09-30-03

Theia JSON: screencast 2019-04-18 09-30-58

VS Code JSON: screencast 2019-04-18 09-31-57

Related https://code.visualstudio.com/updates/v1_27#_auto-closing-surrounding-characters?

akosyakov commented 5 years ago

https://github.com/theia-ide/theia/blob/master/packages/json/src/browser/json-grammar-contribution.ts#L33 should be aligned with https://github.com/Microsoft/vscode/blob/master/extensions/json/language-configuration.json