search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
20.06k stars 2.5k forks source link

fix handling of vscode configuration scopes #5021

Open akosyakov opened 5 years ago

akosyakov commented 5 years ago

See https://github.com/theia-ide/theia/pull/4947#discussion_r278554345

TODO

colin-grant-work commented 3 years ago

@akosyakov, could you expand a little on the functionality that this issue is targeting? From the comment and the reference to the VSCode repo, it looks like the objective is to accurately reflect superset properties of scopes (User ⊃ Workspace ⊃ Folder), so anything valid in folder scope is valid in WS and User, and anything valid in WS is valid in User, but not vice versa. That needs to be reflected in how the schemas for each scope are updated and how the isValidInScope check works, correct? I think a lot of that work may already have been done, but I want to make sure I understand correctly what the desired functionality is.