Ctrl-P does not work when focus is on terminal

[geropl]

Description

When the focus is on the terminal Ctrl-P does not nothing instead of opening the "File chooser".

Other apps:

• VsCode: Open "File chooser", regardless of context/focus
• local terminal app: scroll up in command history

As a User I would expect the VsCode behavior.

Note: This is no problem for Mac users because there "File chooser" action is mapped to "Cmd-P".

Reproduction Steps

Negative:

1. Click on terminal to give focus
2. Hit Ctrl-P => nothing happens

Positive:

1. Click on file navigator to give focus
2. Hit Ctrl-P => File chooser opens

OS and Theia version:

Diagnostics: none

[kittaakos]

I can confirm; it works on macOS from Chome but broken on Windows 10 from Chrom. I used _enUS layout on both OSs if it matters.

Ctrl+P should insert data

Isn't is Ctrl/Cmd+V?

[akosyakov]

@kittaakos deleted my comment already :) thought maybe it have to do something else in terminal, that's why it does nothing, but no looks like a bug

[svenefftinge]

We are capturing all CTRL + x keybindings in the terminal generically so they are passed through to the terminal. We should make an exception for CTRL+P here.

[svenefftinge]

See https://github.com/theia-ide/theia/blob/master/packages/terminal/src/browser/terminal-frontend-contribution.ts#L261

[svenefftinge]

Also see https://github.com/microsoft/vscode/blob/744fefaa0daabba8a3be8122308ddc80fb851b63/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L45