search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.9k stars 2.49k forks source link

[macOS][keybinding] Use ⌘ instead of `Cmd` as the accelerator on macOS #5427

Open kittaakos opened 5 years ago

kittaakos commented 5 years ago

This is UI/UX only. Originally from here: https://github.com/theia-ide/theia/pull/5416#issuecomment-500880300

Update: https://github.com/theia-ide/theia/blob/819ebfe103493ba87e2e5706eb6a54bc4364aecc/packages/core/src/browser/keybinding.ts#L336

Add: https://github.com/theia-ide/theia/blob/819ebfe103493ba87e2e5706eb6a54bc4364aecc/packages/core/src/browser/keyboard/keys.ts#L454

vince-fugnitto commented 5 years ago

Consequently, is this the reason meta is displayed instead of cmd in the keybindings-widget on macOS?

Screen Shot 2019-06-19 at 12 58 50 PM