search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.4k stars 2.45k forks source link

[mini-browser] mini-browser not focused correctly #5560

Open vince-fugnitto opened 5 years ago

vince-fugnitto commented 5 years ago

Description

Currently, when the preview mini-browser editor is used to view an image, clicking within the editor does not set the focus to the entire editor which results in odd behaviors such as the inability to open the quick-command-palette to perform actions. Instead, like the preview for markdown, selecting within the editor should set the focus to the editor itself.

Steps to Reproduce

  1. open an svg file as a preview.
  2. click within the svg file.
  3. attempt to open the quick-commands (F1)

Additional Info

Theia c02c6e2826b07481c400758f53acc6687df7bd5e Ubuntu 16.04 Chrome v74.0.3729.6

vince-fugnitto commented 5 years ago

Potentially related #4368

vince-fugnitto commented 5 years ago

Related to #5521

akosyakov commented 5 years ago

I think we need iframe widget, which handles typical iframe issues and particularly can forward focus/blur events to the host window from iframe window. MiniBrowser and WebView should be reimplemented by using it.

akosyakov commented 4 years ago

I think we should do https://github.com/eclipse-theia/theia/issues/6562 instead.