Closed zwhitchcox closed 5 years ago
We do not yet support Node.js 12+, please use 10.x. For instance, 10.16.0.
I am closing this.
Ok, I just downgraded to 10.16.0, and I'm still getting this error
yarn install v1.16.0
$ node-gyp install
gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@10.15.0 | linux | x64
gyp http GET https://nodejs.org/download/release/v10.15.0/node-v10.15.0-headers.tar.gz
gyp http 200 https://nodejs.org/download/release/v10.15.0/node-v10.15.0-headers.tar.gz
gyp http GET https://nodejs.org/download/release/v10.15.0/SHASUMS256.txt
gyp http 200 https://nodejs.org/download/release/v10.15.0/SHASUMS256.txt
10.15.0
gyp info ok
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
warning monaco-languageclient@0.9.0: The engine "vscode" appears to be invalid.
warning vscode-base-languageclient@4.4.0: The engine "vscode" appears to be invalid.
info fsevents@1.2.4: The platform "linux" is incompatible with this module.
info "fsevents@1.2.4" is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
warning " > istanbul-instrumenter-loader@3.0.1" has unmet peer dependency "webpack@^2.0.0 || ^3.0.0 || ^4.0.0".
warning " > tslint-language-service@0.9.9" has incorrect peer dependency "typescript@>= 2.3.1 < 3".
warning "workspace-aggregator-4f76d8a8-204d-4468-84da-b4581e4fd297 > @theia/application-manager > font-awesome-webpack@0.0.5-beta.2" has unmet peer dependency "font-awesome@>=4.3.0".
warning "workspace-aggregator-4f76d8a8-204d-4468-84da-b4581e4fd297 > @theia/debug > requestretry@3.1.0" has unmet peer dependency "request@2.*.*".
warning "workspace-aggregator-4f76d8a8-204d-4468-84da-b4581e4fd297 > @theia/application-manager > font-awesome-webpack > less-loader@2.2.3" has incorrect peer dependency "less@^2.3.1".
[5/5] Building fresh packages...
[8/14] ⠠ oniguruma
[10/14] ⠠ find-git-repositories
[9/14] ⠠ vscode-ripgrep
[11/14] ⠠ @theia/electron
error /home/zane/dev/theia/node_modules/@theia/electron: Command failed.
Exit code: 127
Command: node scripts/post-install.js
Arguments:
Directory: /home/zane/dev/theia/node_modules/@theia/electron
Output:
gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@10.15.0 | linux | x64
gyp info spawn /usr/bin/python2
gyp info spawn args [ '/home/zane/dev/theia/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'make',
gyp info spawn args '-I',
gyp info spawn args '/home/zane/dev/theia/dev-packages/electron/native/build/config.gypi',
gyp info spawn args '-I',
gyp info spawn args '/home/zane/dev/theia/node_modules/node-gyp/addon.gypi',
gyp info spawn args '-I',
gyp info spawn args '/home/zane/.node-gyp/10.15.0/include/node/common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=/home/zane/.node-gyp/10.15.0',
gyp info spawn args '-Dnode_gyp_dir=/home/zane/dev/theia/node_modules/node-gyp',
gyp info spawn args '-Dnode_lib_file=/home/zane/.node-gyp/10.15.0/<(target_arch)/node.lib',
gyp info spawn args '-Dmodule_root_dir=/home/zane/dev/theia/dev-packages/electron/native',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'build',
gyp info spawn args '-Goutput_dir=.' ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '/home/zane/dev/theia/dev-packages/electron/native/build'
CC(target) Release/obj.target/ffmpeg/src/ffmpeg.o
CC(target) Release/obj.target/ffmpeg/src/linux-ffmpeg.o
SOLINK_MODULE(target) Release/obj.target/ffmpeg.node
COPY Release/ffmpeg.node
make: Leaving directory '/home/zane/dev/theia/dev-packages/electron/native/build'
gyp info ok
Found cached ffmpeg library.
Hashes are equal, not replacing the ffmpeg library.
Error: 2 bad / 18 found
> h264 detected (H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10)
> aac detected (AAC (Advanced Audio Coding))
at main (/home/zane/dev/theia/dev-packages/electron/electron-codecs-test.js:64:15)
at Object.<anonymous> (/home/zane/dev/theia/dev-packages/electron/electron-codecs-test.js:70:1)
at Module._compile (internal/modules/cjs/loader.js:689:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
at Module.load (internal/modules/cjs/loader.js:599:32)
at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
at Function.Module._load (internal/modules/cjs/loader.js:530:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
at startup (internal/bootstrap/node.js:283:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:743:3)
Error: "electron-codecs-test.js" exited with 127
at ChildProcess.subprocess.once (/home/zane/dev/theia/dev-packages/electron/scripts/post-install.js:36:40)
Hashes are equal, not replacing the ffmpeg library. Error: 2 bad / 18 found h264 detected (H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10) aac detected (AAC (Advanced Audio Coding))
Can you please assist with this @marechal-p? Thank you!
@zwhitchcox, since you build it from the source, you can get rid of the electron ffmpg checks: https://github.com/theia-ide/theia/blob/20251eae573ae89f5cf3242131add17f0ef40956/dev-packages/electron/package.json#L34
If you remove this from the package.json
it should not check the codecs. Note, this is just a dirty workaround.
Update: Some details about the codec issue in electron: https://spectrum.chat/theia/dev/cq-issue-lgpl-content-distributed-with-electron~65c94009-dd54-44f2-9811-2dd04d5ffd83
Ok, that got it to work!
The ffmpeg replacement downloads a "clean" library version, then caches the download, and finally compares hashes to see if it needs to replace anything.
From the last logs you sent, it says it found something cached, and that it was identical to the library already installed. Then the test detects the codecs we don't want to distribute. This is not normal, but it is what we wanted to detect.
Can you git clean -xfd
your installation and rebuild everything?
I got similar errors:
yarn
yarn install v1.13.0
$ node-gyp install
gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@10.15.1 | darwin | x64
gyp http GET https://nodejs.org/download/release/v10.15.1/node-v10.15.1-headers.tar.gz
gyp http 200 https://nodejs.org/download/release/v10.15.1/node-v10.15.1-headers.tar.gz
gyp http GET https://nodejs.org/download/release/v10.15.1/SHASUMS256.txt
gyp http 200 https://nodejs.org/download/release/v10.15.1/SHASUMS256.txt
10.15.1
gyp info ok
[1/5] 🔍 Validating package.json...
[2/5] 🔍 Resolving packages...
[3/5] 🚚 Fetching packages...
warning monaco-languageclient@0.9.0: The engine "vscode" appears to be invalid.
warning vscode-base-languageclient@4.4.0: The engine "vscode" appears to be invalid.
[4/5] 🔗 Linking dependencies...
warning " > istanbul-instrumenter-loader@3.0.1" has unmet peer dependency "webpack@^2.0.0 || ^3.0.0 || ^4.0.0".
warning " > tslint-language-service@0.9.9" has incorrect peer dependency "typescript@>= 2.3.1 < 3".
warning "workspace-aggregator-39f402cb-e281-4e11-b157-0c49737d9267 > @theia/application-manager > font-awesome-webpack@0.0.5-beta.2" has unmet peer dependency "font-awesome@>=4.3.0".
warning "workspace-aggregator-39f402cb-e281-4e11-b157-0c49737d9267 > @theia/debug > requestretry@3.1.0" has unmet peer dependency "request@2.*.*".
warning "workspace-aggregator-39f402cb-e281-4e11-b157-0c49737d9267 > @theia/application-manager > font-awesome-webpack > less-loader@2.2.3" has incorrect peer dependency "less@^2.3.1".
[5/5] 🔨 Building fresh packages...
[6/15] ⠐ nsfw
[-/15] ⠐ waiting...
[11/15] ⠐ find-git-repositories
[9/15] ⠐ oniguruma
error /Users/xxxxxxx/projects/vellengs/theia/node_modules/@theia/electron: Command failed.
Exit code: 127
Command: node scripts/post-install.js
Arguments:
Directory: /Users/xxxxxxx/projects/vellengs/theia/node_modules/@theia/electron
Output:
gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@10.15.1 | darwin | x64
gyp info spawn /usr/local/bin/python
gyp info spawn args [ '/Users/xxxxxxx/projects/vellengs/theia/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'make',
gyp info spawn args '-I',
gyp info spawn args '/Users/xxxxxxx/projects/vellengs/theia/dev-packages/electron/native/build/config.gypi',
gyp info spawn args '-I',
gyp info spawn args '/Users/xxxxxxx/projects/vellengs/theia/node_modules/node-gyp/addon.gypi',
gyp info spawn args '-I',
gyp info spawn args '/Users/xxxxxxx/.node-gyp/10.15.1/include/node/common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=/Users/xxxxxxx/.node-gyp/10.15.1',
gyp info spawn args '-Dnode_gyp_dir=/Users/xxxxxxx/projects/vellengs/theia/node_modules/node-gyp',
gyp info spawn args '-Dnode_lib_file=/Users/xxxxxxx/.node-gyp/10.15.1/<(target_arch)/node.lib',
gyp info spawn args '-Dmodule_root_dir=/Users/xxxxxxx/projects/vellengs/theia/dev-packages/electron/native',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'build',
gyp info spawn args '-Goutput_dir=.' ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
CC(target) Release/obj.target/ffmpeg/src/ffmpeg.o
CC(target) Release/obj.target/ffmpeg/src/mac-ffmpeg.o
SOLINK_MODULE(target) Release/ffmpeg.node
gyp info ok
Error: 2 bad / 18 found
> h264 detected (H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10)
> aac detected (AAC (Advanced Audio Coding))
at main (/Users/xxxxxxx/projects/vellengs/theia/dev-packages/electron/electron-codecs-test.js:64:15)
at Object.<anonymous> (/Users/xxxxxxx/projects/vellengs/theia/dev-packages/electron/electron-codecs-test.js:70:1)
at Module._compile (internal/modules/cjs/loader.js:689:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
at Module.load (internal/modules/cjs/loader.js:599:32)
at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
at Function.Module._load (internal/modules/cjs/loader.js:530:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
at startup (internal/bootstrap/node.js:283:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:743:3)
Error: "electron-codecs-test.js" exited with 127
at ChildProcess.subprocess.once (/Users/xxxxxxx/projects/vellengs/theia/dev-packages/electron/scripts/post-install.js:36:40)
at Object.onceWrapper (events.js:277:13)
at ChildProcess.emit (events.js:189:13)
Thanks for reporting it, @vellengs. Did you try?
Can you git clean -xfd your installation and rebuild everything?
Still trying that ...
@kittaakos It works.
closing this issue for now - reopen if needed
Description
Running yarn install gives an error
Reproduction Steps
yarn
OS and Theia version: OS: Ubuntu 18.04 cloned version from master: 20251eae573ae89f5cf3242131add17f0ef40956 Diagnostics: ives this error
I already have g++ and build-essential installed, but running yarn gives this error
Running
sudo apt-get install g++ build-essential
gives