search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
20.05k stars 2.5k forks source link

[fs-watcher] not support soft link watch #5968

Closed 502647092 closed 1 year ago

502647092 commented 5 years ago

Description

fs-watcher not support soft link watch

Reproduction Steps

temp

OS and Theia version: git-commit: 9105c43ab

Diagnostics:

akosyakov commented 5 years ago

Unfortunately nsfw reports an event only for one symlink, not all :( We've decided to resolve all symlinks to real paths: https://github.com/theia-ide/theia/issues/2566#issuecomment-477478224 It covers most of the cases. But obviously we cannot report for all symlinks, since we don't have such information. Also see https://github.com/Axosoft/nsfw/issues/30, implementing it via indexing all symlinks will harm performance

akosyakov commented 5 years ago

As an idea we could try to preserver an information whether the given file node is a symlink or not and to which realpath and refresh it as well when an event is reported. I remember trying something like that but it would fix an issue only for the navigator and design was quite impactful to apis.

havogt commented 4 years ago

I probably encountered this bug with a gitpod setup. I didn't want to enforce .theia/settings.json for the non-gitpod users, so I decided to put the .theia folder in a subdirectory and create a symlink on gitpod init. The effect is that in the debug view, the launch selector doesn't get updated if a new configuration is added to the launch.json file. Here is an example setup to reproduce: https://github.com/havogt/gitpod-playground. Not high priority for me, as I solved the problem with hard links.