eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.98k stars 2.5k forks source link

[keybinding][windows] Keybinding collisions #6153

Open kittaakos opened 5 years ago

kittaakos commented 5 years ago

Description

There is a keybinding collision in Theia. Happens on Windows. ``` root WARN Collided keybinding is ignored; {"command":"passthrough","keybinding":"ctrl+k","context":"terminalActive"} collided with {"command":"terminal:clear","keybinding":"ctrlcmd+k","context":"terminalActive"} ``` ``` root WARN Could not register keybinding: {"command":"passthrough","keybinding":"ctrl+k","context":"terminalActive"} Error: "ctrl+k" is in collision with something else [scope:0] ``` ### Reproduction Steps

Start Theia on Windows.

OS and Theia version: Windows a9a39db21 Diagnostics:

dannaf commented 5 years ago

Am also encountering this issue. (And it's pretty bothersome, since ctrl+k is a useful shortcut that I use often to clear to the end of the line in the terminal).

I have the following info:

$ yarn run start
yarn run v1.17.3
$ theia start --plugins=local-dir:../../plugins
root INFO Theia app listening on http://localhost:3000.
root INFO Detected keyboard layout from browser API: US (PC)
root WARN Collided keybinding is ignored;  {"command":"monaco.editor.action.toggleTabFocusMode","keybinding":"ctrl+m"}  collided with  {"command":"core.toggleMaximized","keybinding":"ctrl+m"}
root WARN Could not register keybinding:
  {"command":"monaco.editor.action.toggleTabFocusMode","keybinding":"ctrl+m"}
Error: "ctrl+m" is in collision with something else [scope:0]
root WARN Collided keybinding is ignored;  {"command":"passthrough","keybinding":"ctrl+k","context":"terminalActive"}  collided with  {"command":"terminal:clear","keybinding":"ctrlcmd+k","context":"terminalActive"}
root WARN Could not register keybinding:
  {"command":"passthrough","keybinding":"ctrl+k","context":"terminalActive"}
Error: "ctrl+k" is in collision with something else [scope:0]

OS and Theia version: Windows 10, Chrome 77.0.3865.120, Theia v0.11.0 browser example