search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.95k stars 2.5k forks source link

View + Side Panel Toolbar interactions #6187

Open caseyflynn-google opened 5 years ago

caseyflynn-google commented 5 years ago

The interactions between the Side Panel Widgets and the View Menu seem a little odd compared to other IDEs. Currently clicking a widget name in the view menu will remove it from the side panel instead of focusing the widget.

vince-fugnitto commented 5 years ago

@caseyflynn-google I agree it's not intuitive, what do you believe the behavior should be?

Perhaps we can do the following (using the search-in-workspace (siw) widget as an example):

Use Case Behavior
Clicking View > Search
(when siw is hidden)		 The search-in-workspace widget is revealed
Clicking View > Search
(when siw is visible)		 The search-in-workspace widget remains revealed
Clicking View > Search
(when siw is doesn't exist)		 The search-in-workspace widget is spawned and revealed
Clicking the Search widget tab
(when siw is hidden)		 The search-in-workspace widget is revealed
Clicking the Search widget tab
(when siw is visible)		 The search-in-workspace widget is collapsed
Right-clicking the Search widget tab and selecting close
(when siw is visible)		 The search-in-workspace widget is closed
akosyakov commented 5 years ago

Added to discuss on next dev meeting.

@vince-fugnitto as far as I understood that only the behavior of opening a view from the main menu bar should be changed, i.e. reveal and focus instead of toggling.

vince-fugnitto commented 5 years ago

Added to discuss on next dev meeting.

@vince-fugnitto as far as I understood that only the behavior of opening a view from the main menu bar should be changed, i.e. reveal and focus instead of toggling.

Yes, I believe so too. I just wanted to explicitly describe each use case for test purposes later :)

akosyakov commented 5 years ago

PRs are welcomed!