No menu items available in Selection menu

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.

http://theia-ide.org

Eclipse Public License 2.0

20.03k stars 2.5k forks source link

No menu items available in Selection menu #731

Closed lmcbout closed 6 years ago

lmcbout commented 7 years ago

Menu "Selection" available, but all options are greyed out. Should we have this menu option available? peek 2017-10-23 selectionmenu

Some discussion took place for issue in yangster: ref: https://github.com/theia-ide/yangster/issues/26

Most of these don't make sense for the diagram. Which ones would you like to use? I don't think that Theia can deactivate entire menus.

-If we use the diagram display and if none of the menu items apply to any diagram, then the menu "Selection" should not clutter the menu bar, it should be invisible when the user is editing/viewing a diagram

kittaakos commented 7 years ago

I would rephrase this: do we want to dynamically update (hide) a particular sub-menu from the main menu if none of the corresponding commands have an active handler?

I believe one has to also keep in mind whether we show an inactive menu item, or we simply omit it when no active handlers are available for the command.

Also related: #446.

svenefftinge commented 6 years ago

I think the behavior is fine, since removing and adding menus based on context would be bad (as we learned in Eclipse). I'd like to close this. Objections?

kittaakos commented 6 years ago

I'd like to close this.

lmcbout commented 6 years ago

Personally, I find it weird having a pull-down menu with no items selectable. Second, The selection menu is also completely empty when starting Theia, if you click on it, a few pixels shows the menu is selected, but nothing else, no menus. Another example. When running yangster, menu items in the "Edit" sub-menu are not needed ("Cut/COPY/PASTE") If there is no plan to make them available, why do we display them when the user is only handling some UI display?

hexa00 commented 6 years ago

If we don't change the menus based on context we should fix the display when there's no items... like adding a empty menu item?

svenefftinge commented 6 years ago

The totally empty main menu (#751) is a bug. I created #760.

svenefftinge commented 6 years ago

When running yangster, menu items in the "Edit" sub-menu are not needed ("Cut/COPY/PASTE") If there is no plan to make them available, why do we display them when the user is only handling some UI display?

I don't understand, could you explain what you mean?

lmcbout commented 6 years ago

If you look at the yangster issue: https://github.com/theia-ide/yangster/issues/29 There seems to be no plan to edit directly into the diagram. Under the "Edit" menu, there are some options to modify the editor : Copy/CUT/PASTE. If there is no plan to use those features, why are they there !!

svenefftinge commented 6 years ago

Copy/Cut/Paste is supported in yangster, generally, just not in the diagram.

svenefftinge commented 6 years ago

Can this ticket be closed, or is there anything we should take action on?