Emojis cause incorrect displaying of the terminal

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.

http://theia-ide.org

Eclipse Public License 2.0

20.04k stars 2.5k forks source link

Open dsseng opened 4 years ago

dsseng commented 4 years ago

Emojis are displayed incorrectly.

OS and Theia version: OS: Ubuntu 19.10 Default shell: zsh 5.7.1 Theia: master

Diagnostics:

I use zsh shell with oh-my-zsh, maybe it's related, but it's used in GNOME Terminal too.

vince-fugnitto commented 4 years ago

I quickly verified on my side and it worked correctly:

Additional Info

I'm using bash_it and I'm on macOS.

akosyakov commented 4 years ago

So it is shell configuration issue, not something what can be addressed in Theia?

dsseng commented 4 years ago

Maybe it's browser-specific.

kittaakos commented 4 years ago

Maybe it's browser-specific.

It's shell specific. Before switching to zsh with Catalina, it worked. I think there is not much we can do.

Screen Shot 2020-04-20 at 10 42 40

dsseng commented 4 years ago

It looks like there isn't :(. Maybe it should be reported to Xterm.js, if they can't do anything report to Zsh.

dsseng commented 4 years ago

@kittaakos do you use oh-my-zsh too? if so, it can be their issue.

dsseng commented 4 years ago

In VS Code there isn't such issue.

kittaakos commented 4 years ago

do you use oh-my-zsh too

No, I don't.

akosyakov commented 4 years ago

it looks like there isn't :(. Maybe it should be reported to Xterm.js, if they can't do anything report to Zsh.

@sh7dm you can give it a go to double check

dsseng commented 4 years ago

What can I check? Xterm.js? Zsh is fine in Gnome Terminal

akosyakov commented 4 years ago

Yes, I meant Xterm.js.

dsseng commented 4 years ago

ok. will try.

dsseng commented 4 years ago

hmm, I found no way to connect it to zsh, but it's zsh-dependant.