eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.9k stars 2.49k forks source link

Command execution buttons (Run | Debug) not available in a JAVA project until we refresh the widget #7748

Open lmcbout opened 4 years ago

lmcbout commented 4 years ago

Bug Description:

It looks like there is an event missing for codelens when the editor needs a refresh after a font change. When I change the font, the "RUN" | "Debug" command are missing over the main class in a JAVA project until I refresh (Just use the scroll button) to refresh the widget.

Steps to Reproduce:

1.Have JAVA dependencies available (JAVA pack + maven) in my configuration

  1. git clone git@github.com:ryanluker/vscode-coverage-gutters.git ( Create a test environment)
  2. Open a file in a JAVA project ( App.java) --> Observe the buttons: "Run " | "Debug" showing over the main class
  3. Open the preference and change the "editor.fontSize": 22
  4. Return to the JAVA file --> The "Run" | "Debug" buttons are not available until you scroll to refresh the widget

Additional Information

RefreshMissingAfterFontChange

vince-fugnitto commented 4 years ago

@lmcbout do you mind updating the description, I don't see how it is related to gitlens.

vince-fugnitto commented 4 years ago

I could not reproduce the issue unfortunately.

lmcbout commented 4 years ago

@vince-fugnitto I added steps to reproduce it, see above.

vince-fugnitto commented 4 years ago

@vince-fugnitto I added steps to reproduce it, see above.

I am still unable to reproduce the error, even with the updated steps.

lmcbout commented 4 years ago

@vince-fugnitto Itest with the latest commit and it happens 100% each time Tested with Chrome on UBUNTU Steps to Reproduce: 1.Have JAVA dependencies available : tested with only the two plugins: redhat.java-0.59.1.vsix vscode-java-test.vsix version 0.22.0 (This is the plugins generating the "RUN" | "DEBUG"

  1. git clone git@github.com:ryanluker/vscode-coverage-gutters.git ( Create a test environment)
  2. Open a file in a JAVA project ( App.java) --> Observe the buttons: "Run " | "Debug" showing over the main class
  3. Open the preference which becomes the active file in editor, the App.java is now hidden Change the "editor.fontSize": 28 --> The file is auto-saved
  4. Select the tab with the App.java --> The "Run" | "Debug" buttons are not available until you scroll to refresh the widget See the following video. On top of it after scrolling, the buttons "RUN" does overlap the code . RunDebugNotShowing
vince-fugnitto commented 4 years ago

@lmcbout A couple of things:

  1. Have JAVA dependencies available : tested with only the two plugins: redhat.java-0.59.1.vsix vscode-java-test.vsix version 0.22.0 (This is the plugins generating the "RUN" | "DEBUG"

Where are you getting your extensions? You referenced specific versions without providing any links, can you either update the comment to provide the extension links or provide your complete package.json?

git clone git@github.com:ryanluker/vscode-coverage-gutters.git ( Create a test environment)

This step is unclear, what do you mean by 'create a test environment'

lmcbout commented 4 years ago

VERSION LINK: "vscode-java-redhat": "https://open-vsx.org/api/redhat/java/0.59.1/file/redhat.java-0.59.1.vsix", "vscode-java-test": "https://github.com/microsoft/vscode-java-test/releases/download/0.22.0/vscjava.vscode-java-test-0.22.0.vsix",

This step is unclear, what do you mean by 'create a test environment'

Just create a clean new workspace, to make sure there is no other side-effect from any other files/plugins

vince-fugnitto commented 4 years ago

@lmcbout your example is incomplete, codelens are provided by vscode-java-debug. Please see:


Update: using vscode-debug version from theia-java image:

![aaa](https://user-images.githubusercontent.com/40359487/81321025-131ab900-9060-11ea-9ef4-915939de92dd.gif)
lmcbout commented 4 years ago

The functionality might be provided by java-debug, but even if the plugin is not installed, thbe "RUN" button shows and this PR show it not being refesh properly when you change the font size