Closed kittaakos closed 3 years ago
@kittaakos at which point do you want the build to fail fast?
We require that @theia/cli
is built before we are able to successfully run the download:plugins
script (which is why it is called after the official yarn
phase since it has no affect on the actual build of the application).
fail fast?
Sorry, I meant to fail ~fast~ at the end 😊More precisely, I want a non-zero exit code if something has not been downloaded. It must not be the default behavior, we did something similar with the dependency hosting check. It logs a warning by default.
I want to avoid one thing: having a green build without the VS Code extensions.
fail fast?
Sorry, I meant to fail ~fast~ at the end 😊More precisely, I want a non-zero exit code if something has not been downloaded. It must not be the default behavior, we did something similar with the dependency hosting check. It logs a warning by default.
I want to avoid one thing: having a green build without the VS Code extensions.
Thank you for clarifying!
Bug Description:
Right now, https://open-vsx.org/ is down.
I want
yarn
to fail fast if the VS Code extension download phase has failed. Otherwise, I get a green build with a non-functional app.Locally:
With GH Actions:
Steps to Reproduce:
1. 2. 3.
Additional Information