search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
20.05k stars 2.5k forks source link

Extension with long text is not fully seen in view -> plugins and not tooltip #8067

Open idantr opened 4 years ago

idantr commented 4 years ago

Bug Description:

Extension with long description - we do not see the full description of the plugin

Steps to Reproduce:

  1. run theia with env variable: THEIA_PLUGINS=local-dir:/<>/git/theia/plugins

screenshot: image

Additional Information

vince-fugnitto commented 4 years ago

@idantr would you like to prepare a pull-request to add the description as part of the tooltip?

akosyakov commented 4 years ago

For VS Code extensions, you should use Extensions view, not Plugins.

akosyakov commented 4 years ago

I'm not sure that we should work on enhancing Plugins view or looking into removing it. It is not used in practice.

vince-fugnitto commented 4 years ago

I'm not sure that we should work on enhancing Plugins view or looking into removing it. It is not used in practice.

I asked a similar question in the past (https://github.com/eclipse-theia/theia/issues/7375), in my opinion it is confusing to have both plugins and the extensions view. My concern however is that those that do not explicitly depend on @theia/vsx-registry will not have a view (since nothing pulls vsx-registry), and/or they might not want access to a marketplace so in that case do they add their own view? Should we add the view to api-samples as a reference?

akosyakov commented 4 years ago

My concern however is that those that do not explicitly depend on @theia/vsx-registry will not have a view (since nothing pulls vsx-registry), and/or they might not want access to a marketplace so in that case do they add their own view? Should we add the view to api-samples as a reference?

I assume they are either have own view or don't want to have view at all. Leaking dev time view to end users not really good.

vince-fugnitto commented 4 years ago

My concern however is that those that do not explicitly depend on @theia/vsx-registry will not have a view (since nothing pulls vsx-registry), and/or they might not want access to a marketplace so in that case do they add their own view? Should we add the view to api-samples as a reference?

I assume they are either have own view or don't want to have view at all. Leaking dev time view to end users not really good.

I'm not sure what you meant by 'dev time view', but my idea was to either:

I do not think that applications should have both views by default (when pulling vsx-registry) since they overlap and one of them (plugins) has a limited set of functionality. It also requires additional maintenance to support both (which is mainly your argument for updating the plugins-view).

@akosyakov you had some comments in the past when I removed the view:

danarad05 commented 4 years ago

@akosyakov @vince-fugnitto @idantr Is solution for this issue agreed upon?

idantr commented 4 years ago

@danarad05 from the above discussion @akosyakov should decide if plugins view should be removed/displayed in a different way or not.

akosyakov commented 4 years ago

You should bring unclear questions to the dev meeting where it would be decided by the community: https://github.com/eclipse-theia/theia/wiki/Dev-Meetings

JonasHelming commented 2 years ago

@vince-fugnitto : Removing "good first issue" label, as requirements seem unclear