eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.97k stars 2.5k forks source link

[debug] Single-clicking in the `call stack` view should automatically open the file in editor #8304

Open kittaakos opened 4 years ago

kittaakos commented 4 years ago

Bug Description:

It works with double-click only.

screencast 2020-08-04 16-59-56

Steps to Reproduce:

1. 2. 3.

Additional Information

akosyakov commented 4 years ago

We need to check whether it respect list and tree VS Code settings.

kittaakos commented 4 years ago

We need to check whether it respect list and tree VS Code settings.

I do not understand this comment.

akosyakov commented 4 years ago

I meant whether this view respects following settings in VS Code:

Screenshot 2020-08-05 at 07 11 13
kittaakos commented 4 years ago

I set the open mode preference to doubleClick, and the files still open with a single click from the call stack view.

Screen Shot 2020-08-05 at 09 01 37

The open mode preference is ignored by the debug view.

Note that some trees and lists might choose to ignore this setting if it is not applicable.

screencast 2020-08-05 09-03-04

akosyakov commented 4 years ago

VS Code reacts to double click as well. The difference is that single click preview, i.e. focus is not transferred and editors are not pinned (previewed). Double click or enter transfers cursor and pin the editor.