search

eclipse-theia / theia

Eclipse Theia is a cloud & desktop IDE framework implemented in TypeScript.
http://theia-ide.org
Eclipse Public License 2.0
19.81k stars 2.47k forks source link

electron: 'save as...' command not added to file menu #9134

Open vince-fugnitto opened 3 years ago

vince-fugnitto commented 3 years ago

Bug Description:

Since we do not support dynamic main-menu items in electron (https://github.com/eclipse-theia/theia/issues/446), the save as... command is never added to the file main-menu.

https://github.com/eclipse-theia/theia/blob/8d5e12accfbd6bbe0cd720d3ebd151b700f4dc80/packages/workspace/src/browser/workspace-frontend-contribution.ts#L152-L155

Is it something we should enable always?

Steps to Reproduce:

  1. start the example-electron application with a workspace
  2. open an editor
  3. open the file main-menu - notice no save as...
vince-fugnitto commented 3 years ago

@kittaakos have you noticed this issue as well? I'm wondering if for electron we enable the save as... always so it is available in the file main-menu.

kittaakos commented 3 years ago

have you noticed this issue as well?

No, I haven't. I open the example electron app, and File > Save as... is there for me.

vince-fugnitto commented 3 years ago

have you noticed this issue as well?

No, I haven't. I open the example electron app, and File > Save as... is there for me.

Odd :( It happens for me on Linux at least, the enablement of the command is flaky at best:

https://user-images.githubusercontent.com/40359487/109672914-7f146380-7b43-11eb-9152-8685a72d58d6.mp4