Closed marcdumais-work closed 1 year ago
@alvsan09 Do you remember if we had considered that extension, and if so, why we did not include it in the pack? Maybe it was not to be found on openVSX
at the time? It's there now, albeit a more recent version.
Ah, looking at the code for the older version available on openVSX
(0.24.0), I see it may not be compatible yet for us:
Maybe we can hold-on merging this PR until we support 1.61.0
?
Maybe we can hold-on merging this PR until we support
1.61.0
?
Right!, I found the reason under the original commit: 118be1597134958edc4e5cf9baf38403e3a26be3 " The extension 'ms-vscode.vscode-js-profile-table' is excluded from this change as it's not passing validation checks i.e. no publisher, no version. In addition, it depends on additional extensions that use a proposed API which is subject to change. "
I noticed while building v1.55.2 that this extension is part of those that are fetched (rather than built in place), like ms-vscode.node-debug and a few others. So I'm adding its name to the pack.
[...] [13:58:47] Starting bundle-marketplace-extensions-build ... [13:58:47] Downloading extension: ms-vscode.node-debug@1.44.19 ... [13:58:47] Downloading extension: ms-vscode.node-debug2@1.42.5 ... [13:58:47] Downloading extension: ms-vscode.references-view@0.0.77 ... [13:58:47] Downloading extension: ms-vscode.js-debug-companion@1.0.9 ... [13:58:47] Downloading extension: ms-vscode.js-debug@1.55.2 ... [13:58:47] Downloading extension: ms-vscode.vscode-js-profile-table@0.0.11 ...