eclipse-theia / vscode-builtin-extensions

Built-in VS Code extensions for Theia
Other
66 stars 35 forks source link

Built-in's in solid version are being unintentionally published as preview #105

Open alvsan09 opened 1 year ago

alvsan09 commented 1 year ago

When publishing buil-in extensions having a version that includes the 'next' word on it, they are supposed to be marked as 'preview' which allow consumers to easily identify them before consuming them

however as it can be seen in the picture; Extensions with solid revisions have been already published with the 'preview' flag set to 'true'

There are two sides of this issue: 1) Correct the logic, so 'next' versions are the only ones marked as 'preview' 2) Investigate how to correct this in the data base.

Screenshot from 2022-12-14 12-51-53.

marcdumais-work commented 1 year ago

Alvaro, as discussed, we currently include the package.json preview flag only for preview (next) extensions:

"preview": true

We can try including it in the future, but set to false for solid revisions and see if it helps.

For what's already published, it seems openvsx would need to revisit their interpretation of what it means when the flag is not present.

Examples of the current situation:

No preview flag is set in package.json, for solid versions. e.g.: https://open-vsx.org/api/vscode/bat/1.62.3/file/vscode.bat-1.62.3.vsix

The preview flag is set (to true) for next versions: https://open-vsx.org/api/vscode/bat/1.63.0-next.66b1668b667/file/vscode.bat-1.63.0-next.66b1668b667.vsix

amvanbaren commented 1 year ago

Hi @marcdumais-work, I think you want to use the --pre-release[1] flag for next versions. It used to be that preview[2] had the functionality of pre-release, but now these flags work the same as on the MS marketplace.

In short, preview is an indicator to a user that the extension (all versions) is not yet feature complete and may contain bugs. While pre-release lets a user regularly get the latest extension version before the official extension release.